Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-acceleration.md to include non SDK project reference #9449

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davepcallan
Copy link

@davepcallan davepcallan commented Apr 16, 2024

Update to include reference to build acceleration being available for non sdk-projects from 17.8

Microsoft Reviewers: Open in CodeFlow

Update to include reference to build acceleration being available for non sdk-projects from 17.8
@davepcallan davepcallan requested a review from a team as a code owner April 16, 2024 22:28
@drewnoakes
Copy link
Member

Thanks @davepcallan! You're right that we should cover this topic in the doc.

My concern is that the implementations differ somewhat between project systems, and so some of the rest of the document does not apply to non-SDK-style projects. I think that instead we can add a new section talking about non-SDK-style projects.

Pinging @jacdavis for input on what that content should be.

@drewnoakes drewnoakes added Community Pull request from the community. Thanks for your contribution! Documentation Feature-Build-Acceleration Build Acceleration can skip calls to MSBuild within Visual Studio labels Apr 17, 2024
@davepcallan
Copy link
Author

Thanks @davepcallan! You're right that we should cover this topic in the doc.

My concern is that the implementations differ somewhat between project systems, and so some of the rest of the document does not apply to non-SDK-style projects. I think that instead we can add a new section talking about non-SDK-style projects.

Pinging @jacdavis for input on what that content should be.

Thanks Drew, ah right, it's make sense if the both differ slightly to add a dedicated section for the non-SDK implementation. Close this PR if you like.

@kvenkatrajan kvenkatrajan self-requested a review May 3, 2024 23:06
@kvenkatrajan kvenkatrajan marked this pull request as draft May 3, 2024 23:06
@drewnoakes
Copy link
Member

Pinging @jacdavis for guidance on what content we should include here. I'm happy to help with the writing, just need the bullet points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Pull request from the community. Thanks for your contribution! Documentation Feature-Build-Acceleration Build Acceleration can skip calls to MSBuild within Visual Studio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants