Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUTDC detects changes to Pack items #9437

Merged

Commits on Apr 5, 2024

  1. FUTDC detects changes to Pack items

    When a project specifies `GeneratePackageOnBuild`, additional items become inputs to the FUTDC. Without this, it's possible to change a `Content` item, for example, that has `Pack="true"` metadata, and not have those changes included in the generated NuGet package during builds.
    
    This change includes all the items that NuGet would include in the package as inputs to the FUTDC.
    
    Note that ideally we would only include these items when `GeneratePackageOnBuild` was `true`, however we force the property to `false` during design-time builds in `GeneratePackageOnBuildDesignTimeBuildPropertyProvider`, so instead we add these items unconditionally. It's possible that this could trigger a few extra builds for some uncommon project configurations, but that seems unlikely and is better than failing to build correctly.
    drewnoakes committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    775a9ef View commit details
    Browse the repository at this point in the history