Check if a custom namespace has been specified when generating the Settings designer class. #9174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsider the DefaultNamespace parameter if it's not empty. This would fix the scenario where the user has a custom namespace set up and will generate the correct code in the Settings.Designer.vb file.
Simplify name, simplify variable creation and use an explicit string comparison.
melytc
added
Bug
Feature-Settings-Designer
melytc
changed the title
smitpatel
approved these changes
Jul 18, 2023
drewnoakes
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1708985
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1845024
We got a couple of feedback tickets around VB projects having their namespace wrongly generated to the
Mynamespace on theSettings.Designer.vbfile, instead of their custom namespace.Back in 2022, we added some logic to the
SettingsSingleFileGeneratorBase.vbto include theMynamespace if the project was VB; we forgot to include a consideration for custom namespaces, which would be found in theDefaultNamespaceparameter when callingCreate.Microsoft Reviewers: Open in CodeFlow