Base framework for In Product Acquisition (for review, but will not be merged) #6220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
changed the title
davidwengier
force-pushed
the
TestingInProduceAcquisition
branch
from
e2dea1f
to
6673f8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress, so won't be merged, but the "frameworky" bits of this are done enough for you all to review it and tell me where I went wrong. Ignore the actual scenario (I marked the files with comments), thats just for me to make this code actually do something. Also the
TargetDescriptionBaseand its subclasses will likely change over time, as individual scenarios are built out, but I prefer to do that from a consumption point of view rather than designing everything in theory up front.Part of #6080 and specifically fixes AB#1124216.
The design is this:
Microsoft Reviewers: Open in CodeFlow