FUTDC detects changes to Pack items #9437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a project specifies `GeneratePackageOnBuild`, additional items become inputs to the FUTDC. Without this, it's possible to change a `Content` item, for example, that has `Pack="true"` metadata, and not have those changes included in the generated NuGet package during builds. This change includes all the items that NuGet would include in the package as inputs to the FUTDC. Note that ideally we would only include these items when `GeneratePackageOnBuild` was `true`, however we force the property to `false` during design-time builds in `GeneratePackageOnBuildDesignTimeBuildPropertyProvider`, so instead we add these items unconditionally. It's possible that this could trigger a few extra builds for some uncommon project configurations, but that seems unlikely and is better than failing to build correctly.
drewnoakes
added
the
Feature-Up-to-date
kvenkatrajan
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9433
When a project specifies
GeneratePackageOnBuild, additional items must become inputs to the FUTDC. Without this, it's possible to change aContentitem, for example, that hasPack="true"metadata, and not have those changes included in the generated NuGet package during builds.This change includes all the items that NuGet would include in the package as inputs to the FUTDC.
Note that ideally we would only include these items when
GeneratePackageOnBuildwastrue, however we force the property tofalseduring design-time builds inGeneratePackageOnBuildDesignTimeBuildPropertyProvider, so instead we add these items unconditionally. It's possible that this could trigger a few extra builds for some uncommon project configurations, but that seems unlikely and is better than failing to build correctly.Microsoft Reviewers: Open in CodeFlow