Duplicate root namespace in settings file with sdk-style project

[tgillbe]

Visual Studio Version: 16.9.3

Summary:
When using an SDK-style project and vb.net, the automated tool generates a duplicate root namespace for settings files.

Steps to Reproduce:

1. Create a new SDK-style project for vb.net:

<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net472</TargetFramework>
    <UseWindowsForms>true</UseWindowsForms>
    <StartupObject>Test.Module1</StartupObject>
    <RootNamespace>Test</RootNamespace>
  </PropertyGroup>
  <ItemGroup>
    <Reference Include="mscorlib" />
  </ItemGroup>
  <ItemGroup>
    <Compile Update="MySettings.Designer.vb">
      <DesignTimeSharedInput>True</DesignTimeSharedInput>
      <AutoGen>True</AutoGen>
      <DependentUpon>MySettings.settings</DependentUpon>
    </Compile>
  </ItemGroup>
  <ItemGroup>
    <None Update="My Project\Settings.settings">
      <Generator>SettingsSingleFileGenerator</Generator>
    </None>
    <None Update="MySettings.settings">
      <Generator>SettingsSingleFileGenerator</Generator>
      <LastGenOutput>MySettings.Designer.vb</LastGenOutput>
    </None>
  </ItemGroup>
</Project>

2. Add a new settings file (test file is called MySettings.settings).
3. Inspect the generated MySettings.Designer.vb file.

Expected Behavior:

MySettings.Designer.vb should not wrap the code in the RootNamespace namespace, as that is automatically done by vb.net. This results in a duplicate namespace (i.e. Test.Test.MySettings).

This is what I expect the MySettings.Designer.vb file to look like:

Actual Behavior:

MySettings.Designer.vb has duplicated namespace:

User Impact:

Having to manually remove the namespace after saving the settings file or compile errors when referring to classes with their fully qualified name.

The correct code results when the RootNamespace is removed from the vb.net project but then all other classes fall out of the namespace. I'm pretty sure it doesn't do this when you use the legacy project style as the problem only showed up after switching to the SDK-style project.

[ocallesp]

this still reproes.

The Designer.cs is created in Dotnet ProjectSystem
SettingsSingleFileGeneratorBase.Generate( string wszDefaultNamespace )
and wszDefaultNamespce is coming from CPS

This is the method that generates namespaces in CPS
SingleFileGeneratorService.GetCustomToolNamespaceAsync()

[ocallesp]

@tmeschter

In C Sharp the namespace is added

and the current behavior in VB is the same

SettingsSingleFileGenerator adds a namespace to CS and VB.

What I see different is that when you hover your mouse over the class definition, you will see that in VB the namespace appears twice. Have any idea of why in VB this is different ?

[ocallesp]

1. Define the right behavior in VB
2. Investigate (and perhaps this is not us) why we see an incorrect namespace when we hover over the class definition

[kvenkatrajan]

@ocallesp

This is in our codebase, the namespace should be removed (legacy project system does not add additional namespace)

project-system/src/Microsoft.VisualStudio.Editors/SettingsDesigner/SettingsSingleFileGeneratorBase.vb

Lines 141 to 149 in b6ca713

	' for VB, we need to generate some code that is fully-qualified, but our generator is always invoked
	' without the project's root namespace due to VB convention. If this is VB, then we need to look
	' up the project's root namespace and pass that in to Create in order to be able to generate the
	' appropriate code.
	'
	Dim projectRootNamespace As String = String.Empty
	If isVB Then
	projectRootNamespace = GetProjectRootNamespace()
	End If