Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported MyApplication Properties removed from Application.Designer.VB #6659

Closed
Tracked by #8766
paul1956 opened this issue Oct 7, 2020 · 4 comments
Closed
Tracked by #8766
Assignees
Labels
Area-VisualBasic Specific to the VB.NET language. Feature-Legacy-Application-Designer The "Application Designer" otherwise known as the legacy project properties Triage-Investigate Reviewed and investigation needed by dev team
Milestone

Comments

@paul1956
Copy link

paul1956 commented Oct 7, 2020

Visual Studio Version:
Version 16.8.0 Preview 3.2

Summary:
There are properties in MyApplication like MinimumSplashScreenDisplayTime that the VS UI does not (yet) support that need to be set manually in Application.Designer.VB, this was also true in Framework.

Steps to Reproduce:

  1. Add Me.MinimumSplashScreenDisplayTime = 5000 to Sub New in Application.Designer.VB
  2. Update something (for example IsSingleInstance) in VS UI
  3. Rebuild

Expected Behavior:
The line Me.MinimumSplashScreenDisplayTime = 5000 is not modified
Actual Behavior:
The line Me.MinimumSplashScreenDisplayTime = 5000 is deleted
User Impact:
Application works differently under .Net then it did under Framework. MinimumSplashScreenDisplayTime was not supported in Framework UI but VS just left it alone. There are a few other properties that might me an issue for someone but this is the only one that I have seen frequently used.

@jjmew jjmew added this to the 16.9 milestone Oct 9, 2020
@jjmew jjmew added the Area-VisualBasic Specific to the VB.NET language. label Oct 9, 2020
@jjmew jjmew added the Triage-Investigate Reviewed and investigation needed by dev team label Oct 20, 2020
@jjmew jjmew modified the milestones: 16.9, 16.10 Feb 9, 2021
@jjmew jjmew modified the milestones: 16.10, 17.0 Jun 22, 2021
@MiYanni MiYanni modified the milestones: 17.0, 17.1 Aug 24, 2021
@drewnoakes drewnoakes added the Feature-Legacy-Application-Designer The "Application Designer" otherwise known as the legacy project properties label Dec 7, 2021
@melytc melytc modified the milestones: 17.1, 17.2 Dec 7, 2021
@melytc melytc modified the milestones: 17.2, 17.3 Mar 14, 2022
@ocallesp
Copy link
Contributor

@melytc For this GitHub, do we need to add a new property MinimumSplashScreenDisplayTime into the PP Application ?

@ocallesp
Copy link
Contributor

This functionality was not implemented in the old property pages and implementing this requires a lot of work in the old project system. We should invest time implementing this in the new property pages.

@melytc
Copy link
Contributor

melytc commented Nov 10, 2022

Pending work: validate that this does not happen in the new experience.

@melytc melytc modified the milestones: 17.3, 17.5 Nov 10, 2022
@melytc
Copy link
Contributor

melytc commented Jan 5, 2023

Update: this is still happening in the new experience. If the user manually sets a property in the Application.Designer.VB file without first saving it or rebuilding the project, the change will be lost.

One note is that this file is not supposed to be edited: it states in the header that it is auto generated, and changes should come from the Project Properties. So, to fix this bug, the correct approach should be adding the properties to the UI, so a user is not in the need to change this file.

Hence, this would be fixed by the issue #8286 .

@melytc melytc modified the milestones: 17.5, 17.6 Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-VisualBasic Specific to the VB.NET language. Feature-Legacy-Application-Designer The "Application Designer" otherwise known as the legacy project properties Triage-Investigate Reviewed and investigation needed by dev team
Projects
None yet
Development

No branches or pull requests

6 participants