Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

Add WinUsb_WritePipeAsync, WinUsb_ReadPipeAsync #513

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Add WinUsb_WritePipeAsync, WinUsb_ReadPipeAsync #513

merged 2 commits into from
Jul 17, 2020

Conversation

qmfrederik
Copy link
Contributor

No description provided.

Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some memory management concerns, but otherwise looks good.

src/WinUsb/WinUsb.Helpers.cs Outdated Show resolved Hide resolved
src/WinUsb/WinUsb.Helpers.cs Outdated Show resolved Hide resolved
src/WinUsb/WinUsb.Helpers.cs Outdated Show resolved Hide resolved
src/WinUsb/WinUsb.Helpers.cs Outdated Show resolved Hide resolved
src/WinUsb/WinUsb+WinUsbOverlapped.cs Outdated Show resolved Hide resolved
@qmfrederik qmfrederik mentioned this pull request Jul 17, 2020
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@AArnott AArnott merged commit c493509 into dotnet:master Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants