This repository has been archived by the owner on Jul 26, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsan-madhavan
force-pushed
the
procssthreadsapi-p2
branch
from
July 7, 2020 07:29
1357054
to
583d967
Compare
AArnott
suggested changes
Jul 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this sizeable contribution. :)
vatsan-madhavan
force-pushed
the
procssthreadsapi-p2
branch
from
July 9, 2020 03:41
583d967
to
975a33c
Compare
I see the merge conflict - I’ll resolve soon. |
@vatsan-madhavan Resolving the PublicAPI.Unshipped.txt conflict can be really hairy. So just a tip: clear the whole file out, and use the language service to fully re-populate it. |
AArnott
reviewed
Jul 9, 2020
thanks - that worked well. |
vatsan-madhavan
force-pushed
the
procssthreadsapi-p2
branch
from
July 10, 2020 07:13
5b22c96
to
7fe004c
Compare
AArnott
approved these changes
Jul 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #491
Functions
<< plus a test >>
Structs/types
Additional types