-
-
Notifications
You must be signed in to change notification settings - Fork 223
Conversation
322a92a
to
7ece469
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing!
- Remove SIZE_T - use UIntPtr instead; C# 9 can leverage nuint. - Address review feedback - Replace IntPtr parameters with pointers. - Use FriendlyFlags.Optional where appropriate. - Update tests.
Addressed comments so far. Outstanding at this time:
|
I couldn't tag |
True, |
Create a new one.
Future use option sounds good. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question about that test delegate
Thanks for fixing up the branch and appreciate the feedback + help 👍 |
Thank you for the submission! |
CreateThread
,CreateRemoteThread
,CreateRemoteThreadEx
CreateThreadFlags
enumFriendlyFlags.NativeInt
flag applicable toIntPtr
andUIntPtr
types that are used as a proxy for Win32SIZE_T
type.nint
/nuint
.SIZE_T
and tag them withFriendlyFlag.NativeInt
.Fixes #428