Add benchmark for large number of ConfigurationProvider #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eerhardt
reviewed
Aug 22, 2022
...nchmarks/micro/libraries/Microsoft.Extensions.Configuration/ConfigurationBinderBenchmarks.cs
Outdated
Show resolved
Hide resolved
...nchmarks/micro/libraries/Microsoft.Extensions.Configuration/ConfigurationBinderBenchmarks.cs
Outdated
Show resolved
Hide resolved
…ion/ConfigurationBinderBenchmarks.cs Co-authored-by: Eric Erhardt <[email protected]>
IDisposable
approved these changes
Aug 23, 2022
eerhardt
reviewed
Aug 24, 2022
...nchmarks/micro/libraries/Microsoft.Extensions.Configuration/ConfigurationBinderBenchmarks.cs
Outdated
Show resolved
Hide resolved
...nchmarks/micro/libraries/Microsoft.Extensions.Configuration/ConfigurationBinderBenchmarks.cs
Outdated
Show resolved
Hide resolved
...nchmarks/micro/libraries/Microsoft.Extensions.Configuration/ConfigurationBinderBenchmarks.cs
Outdated
Show resolved
Hide resolved
…ion/ConfigurationBinderBenchmarks.cs Co-authored-by: Eric Erhardt <[email protected]>
Co-authored-by: Eric Erhardt <[email protected]>
eerhardt
approved these changes
Aug 25, 2022
|
@adamsitnik - are the CI failures expected? I tried looking at them, and none of them seemed related to this change, but I couldn't be sure. |
adamsitnik
reviewed
Aug 26, 2022
...nchmarks/micro/libraries/Microsoft.Extensions.Configuration/ConfigurationBinderBenchmarks.cs
Outdated
Show resolved
Hide resolved
...nchmarks/micro/libraries/Microsoft.Extensions.Configuration/ConfigurationBinderBenchmarks.cs
Outdated
Show resolved
Hide resolved
…ion/ConfigurationBinderBenchmarks.cs Co-authored-by: Adam Sitnik <[email protected]>
wangyuantao
changed the title
eerhardt
reviewed
Aug 29, 2022
...nchmarks/micro/libraries/Microsoft.Extensions.Configuration/ConfigurationBinderBenchmarks.cs
Show resolved
Hide resolved
eerhardt
approved these changes
Aug 30, 2022
|
Thank you for reviewing my code and get them merged, @eerhardt @IDisposable @adamsitnik ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InternalConfigurationRootExtensions.GetChildrenImplementation performance can be improved - the time complexity is none-linearly increasing with the ConfigurationProvider count.