add more MemoryCache benchmarks #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
approved these changes
Dec 1, 2020
src/benchmarks/micro/libraries/Microsoft.Extensions.Caching.Memory/MemoryCacheTests.cs
Outdated
Show resolved
Hide resolved
| cache.Remove(item.key); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Should we add a SlidingExpiration test as well? The above test is for absoluteExpirationRelativeToNow AFAICT.
There was a problem hiding this comment.
@eerhardt we should, thanks for pointing this out! I could not find an extension method that would allow for setting SlidingExpiration so I've changed all the benchmarks to use the using pattern for adding the entries (used by the extension methods)
…mory/MemoryCacheTests.cs Co-authored-by: Eric Erhardt <[email protected]>
|
the CI failures are not related to this change, I am merging |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.