ProviderTypeLoader: do not enumerate types in ReflectionOnly assembly. #2869
Conversation
…. Improve logging.
| @@ -87,6 +87,14 @@ private void ProcessAssemblyLocally(Assembly assembly) | |||
|
|
|||
| private static void ProcessNewAssembly(object sender, AssemblyLoadEventArgs args) | |||
| { | |||
| #if !NETSTANDARD | |||
| // If the assembly is loaded for reflection only avoid processing it. | |||
| if (args.LoadedAssembly.ReflectionOnly) | |||
There was a problem hiding this comment.
The linked issue doesn't look like it was related to the ProviderTypeLoader. What led you to here?
Also, I think that because this is wired to the AppDomain.AssemblyLoad event, it should not be getting called when a reflection-only assembly is loaded (I might be wrong, because there's too much black magic with this context, but I think that's what I remember).
There was a problem hiding this comment.
I thought I had replied to this, but apparently not.
This was just me enumerating usages of GetDefinedTypes to see where it was being potentially used incorrectly. AssemblyLoad is called when asms are loaded ReflectionOnly - I tested in a clean project.
There was a problem hiding this comment.
OK, and I assume it still works correctly with custom providers that are loaded via reflection, right? We scan for IProvider in a separate step, but by the time it reaches here it should already be fully loaded?
There was a problem hiding this comment.
When a provider dll is loaded as non-ReflectionOnly, it will call this again with that asm.
Eventually, we need to overhaul AssemblyLoaded and avoid ReflectionOnly
There was a problem hiding this comment.
I meant, we would only fully load the assembly once we first did a pass via reflection-only and found that there is at least one type that implements IProvider (unless I'm not remembering correctly). That step is separate from this, or is this the step that actually scans the reflection only assemblies and decides whether to fully load it?
There was a problem hiding this comment.
The code path which is called hits RegisterProviderType which would fail for a ReflectionOnly type.
There was a problem hiding this comment.
Ok, sounds good. I checked and the code I was referring to happens before this is hit, so it's as expected. BTW, I was referring to:
and (which first scans assemblies using reflection-only, and if it finds something that implements IProvider, it fully loads them)
…. Improve logging. (dotnet#2869)
…. Improve logging. (#2869)
Also improve logging for errors in
TypeUtils.GetDefinedTypes(...)so that loader exceptions are made apparent.Intention is to make debugging issues like #2840 more obvious