Add a timeout for socket connection #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aww. 'Socket' does not contain a definition for 'BeginConnect' and no extension method 'BeginConnect' accepting a first argument of type 'Socket' could be found (are you missing a using directive or an assembly reference?) [D:\j\workspace\netstandard-w---f16d272e\vNext\src\Orleans\Orleans.csproj] without much investigation , I think in netstandard, Socket may not have an method of BeginConnect. You need to find an alternative for that |
|
Great... I Have to use the over complicated ConnectAsync for that... |
|
@dotnet-bot Test this please |
|
LGTM. |
sergeybykov
pushed a commit
to sergeybykov/orleans
that referenced
this pull request
Mar 17, 2017
jdom
pushed a commit
that referenced
this pull request
Mar 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2788
It seems that the value by default is around 20 seconds.
I added a method in
SocketManagerto be able to specify a timeout from the configuration, and use it for client->gw and silo->silo socket connect.