fix missing check for empty deployment id #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeybykov
reviewed
Feb 28, 2017
src/OrleansRuntime/Silo/Silo.cs
Outdated
| } | ||
|
|
||
| private const string CLUSTER_ID_DEFAULT = "A"; // if no id is configured, we pick a nonempty default. |
There was a problem hiding this comment.
I think it's better to put something more meaningful than "A", e.g. "DefaultClusterID".
There was a problem hiding this comment.
fair enough.
sergeybykov
pushed a commit
to sergeybykov/orleans
that referenced
this pull request
Mar 17, 2017
jdom
pushed a commit
that referenced
this pull request
Mar 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the bug observed in #2774.
The problem was that cluster-id was picking deployment-id as a default, but deployment-id can be null or empty. This PR adds a check to catch this and use an appropriate default in all cases.