Allow serializers to have multiple [Serializer(...)] attributes #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
changed the title
ReubenBond
force-pushed
the
multiple-serializer-attrs
branch
4 times, most recently
from
9d5462e to
ceaabe9
Compare
|
@dotnet-bot test this please |
ReubenBond
force-pushed
the
multiple-serializer-attrs
branch
from
ceaabe9 to
6c4fc48
Compare
|
@dotnet-bot test this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work to obviate
SerializationManager.Registermethods. See #2610Simple fix to allow a single static serializer class to support multiple types, as can be seen with the JSON serializer below.
[RegisterSerializer]is still available and this PR adds a test to ensure it's still being called, but it's marked as obsolete in order to set expectations.