-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix oversharing of build results in ResultsCache #9987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uest data,.." (dotnet#9718)" This reverts commit 553649b.
ladipro
force-pushed
the
9458-build-cache
branch
from
April 10, 2024 12:33
27745c6
to
d24ccfc
Compare
rainersigwald
approved these changes
Apr 16, 2024
YuliiaKovalova
approved these changes
Apr 16, 2024
I have removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9458
Context
#9565 had to be reverted because the assumption that results with
BuildRequestDataFlags.ProvideSubsetOfStateAfterBuild
don't have to be cached broke design-time builds in Visual Studio.Changes Made
Re-did the change, now with full handling of
BuildRequestDataFlags.ProvideSubsetOfStateAfterBuild
.Testing
New and existing unit tests, experimental insertion, manual testing with the problematic design-time build scenario.
Notes
Compared to #9565, we now:
BuildResult
in theBuildResult
copy constructor.ProjectInstance
remember the project state filter it was created from.IsSubsetOf
operator onRequestedProjectState
.IsSubsetOf
to determine if a request withProvideSubsetOfStateAfterBuild
can be satisfied by the cache.SkipNonexistentTargets
to be a flag affecting build results.