[release/vs17.10] Fix issue with assemblies locking #9974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
since we plan to service this pr, I assume this localization can be safely delivered too |
ladipro
approved these changes
Apr 4, 2024
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
JanKrivanek
approved these changes
Apr 4, 2024
|
/backport to main |
|
Started backporting to main: https://github.com/dotnet/msbuild/actions/runs/8556564619 |
|
@YuliiaKovalova backporting to main failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: dispose AssemblyInformation
Applying: bump version
Using index info to reconstruct a base tree...
M eng/Versions.props
Falling back to patching base and 3-way merge...
Auto-merging eng/Versions.props
CONFLICT (content): Merge conflict in eng/Versions.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 bump version
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@YuliiaKovalova an error occurred while backporting to main, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
rainersigwald
approved these changes
Apr 10, 2024
surayya-MS
added a commit
that referenced
this pull request
Apr 11, 2024
* Translation update from OneLocBuild (#9963) * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9347357 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9347357 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9394753 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9394753 * Remove spurious `Ł` character in Italian version string --------- Co-authored-by: Rainer Sigwald <[email protected]> * Dispose AssemblyInformation in GetAssembliesMetadata (#9974) Fixes AB#2017198 by releasing the handle to the file by disposing the AssemblyInformation deterministically. * Update package version to 17.10.2 (#9994) --------- Co-authored-by: dotnet bot <[email protected]> Co-authored-by: Rainer Sigwald <[email protected]> Co-authored-by: YuliiaKovalova <[email protected]> Co-authored-by: Surayya Huseyn Zada <[email protected]>
surayya-MS
pushed a commit
to surayya-MS/msbuild
that referenced
this pull request
Apr 11, 2024
Fixes AB#2017198 by releasing the handle to the file by disposing the AssemblyInformation deterministically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The issue is related to the presence of disposable resource that wasn't cleaned up in time.
Customer Impact
Absence of dispose causes "warning MSB3026: Could not copy ".dll". Beginning retry 1 in 1000ms. The process cannot access the file '.dll' because it is being used by another process. The file is locked by: "MSBuild.exe" and it's presence breaks project building.
Regression?
Yes, was introduced in scope of https://github.com/dotnet/msbuild/pull/9313/files#diff-0c7ff4eddab39e683e61e6f11011eac73dae76d2574999184b3c0e74f9c2fa10
Testing
Manual -the problem wasn't caught locally, but manual testing doesn't expose any side effects.
Risk
Low, doesn't contain any changes in logic.