Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix forwarding logger #9650

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Bugfix forwarding logger #9650

merged 3 commits into from
Jan 18, 2024

Conversation

JanKrivanek
Copy link
Member

Fixes #9578 (comment)

Context

Forwarding logger might be configured to forward messages of particular importance regardless of the verbosity level of said logger.
GetMinimumMessageImportance should properly reflect that

Testing

Manual testing with the repro case (building msbuild with terminal logger)

ladipro
ladipro approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@ladipro ladipro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Should the code change be reflected in the GetMinimumMessageImportance method comment?

@JanKrivanek JanKrivanek merged commit f9b862a into dotnet:main Jan 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladipro ladipro ladipro approved these changes

@YuliiaKovalova YuliiaKovalova YuliiaKovalova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JanKrivanek @ladipro @YuliiaKovalova