Fix parsing GB18030 #9623
Merged
Fix parsing GB18030 #9623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we fix other usages of |
JanKrivanek
approved these changes
Jan 10, 2024
It is handled in the other production places already (we have 2 more only) |
rokonec
approved these changes
Jan 11, 2024
rainersigwald
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
1921343
Context
XDocument.Load doesn't handle parsing GB18030 symbols and returns path like 𬴂龨苘爫麤υ㏑%EE%80%B8䡫3\𬴂龨苘爫麤υ㏑%EE%80%B8䡫3 instead of 𬴂龨苘爫麤υ㏑䡫3\𬴂龨苘爫麤υ㏑䡫3. It causes System.IO.DirectoryNotFoundException.
Changes Made
Using XmlReader for handling encoding issues.
Testing
UT + manual