Stop disabling CA1416 Fixes #6376 #7471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
Mar 16, 2022
| @@ -624,9 +624,7 @@ internal static bool IsMaxPathLegacyWindows() | |||
| } | |||
| } | |||
|
|
|||
| // CA1416 warns about code that can only run on Windows, but we verified we're running on Windows before this. | |||
| // This is the most reasonable way to resolve this part because other ways would require ifdef'ing on NET472. | |||
| #pragma warning disable CA1416 | |||
There was a problem hiding this comment.
There should be a corresponding
#pragma warning restore CA1416That should also be removed (for all of these).
Forgind
added
the
merge-when-branch-open
benvillalobos
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6376
Context
We had disabled these before we had the more convenient SupportedOSPlatformGuard. Now we can use that instead.
Changes Made
Replaced #pragma warning disable CA1416s with SupportedOSPlatform("windows")
Testing
Built