Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add targetpath metadata to file getting added to ContentWithTargetPath group #7303

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

sujitnayak
Copy link
Contributor

@sujitnayak sujitnayak commented Jan 19, 2022

Fixes AB#1461672 / https://developercommunity.visualstudio.com/t/Unable-to-publish-via-ClickOnce-for-Unpa/1631852

Context

Apps referencing Windows App SDK packages fail ClickOnce publish due to a copy error for apphost.exe.

Apps with this package reference invoke targets that try to copy files in the ContentWithTargetPath to the output folder. ClickOnce targets add apphost.exe to ContentWithTargetPath w/o the TargetPath metadata. This results in the copy error.

Changes Made

Add TargetPath metadata to the item before it gets added to ContentWithTargetPath group.

Testing

CTI team has run test cases for clickonce publish across all supported configuration

Notes

@rainersigwald rainersigwald added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Jan 20, 2022
@rainersigwald rainersigwald added this to the VS 17.2 milestone Jan 20, 2022
@sujitnayak sujitnayak merged commit 3c8fb11 into dotnet:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants