-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NuGet package READMEs #7291
Conversation
This should improve understandablity of our packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for doing this :) I built locally with ./build.cmd -pack
and verified the packages via nuget.info, so this is all set from my perspective.
@@ -1,27 +1,29 @@ | |||
<Project> | |||
|
|||
<PropertyGroup> | |||
<PackageReadmeFile>README.md</PackageReadmeFile> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this trick, I do it on all of my multi-package projects :D
After this PR, should this doc still exist? |
Hm, I think having the pointers to the packages still makes sense but it can be streamlined. I'm also going to steal some of that text for the new READMEs 🤦🏻 |
redistribute the MSBuild runtime to evaluate or build MSBuild projects within their application. This can be necessary because prior to MSBuild version 15, MSBuild was installed globally on a machine and universally | ||
available to all applications. However, in MSBuild version 15 and forward, MSBuild is redistributed by each application that uses it and applications are unable to share other instances. | ||
|
||
This package delivers a complete executable copy of MSBuild. Reference this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I'd ever heard of this 😮
This should improve understandablity of our packages.
Fixes #6991.
Details on the format: