Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start windowless process for the KillTree test #7283

Merged

Conversation

MichalPavlik
Copy link
Member

Fixes #7255

Context

KillTree test starts a powershell process during execution. When the default terminal is set to Windows Terminal, the WT window is still opened after test execution.

Changes Made

Test now starts windowless process.

Testing

The KillTree test is still passing.

Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Jan 13, 2022
@ladipro ladipro merged commit d75dd35 into dotnet:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'KillTree' test leaves Windows Terminal window opened
5 participants