Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MSBuild.Engine.Corext #7278

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

rainersigwald
Copy link
Member

This package was used for some internal Microsoft teams but overrides
a very old version of the MSBuild.CoreXT package (15.0!) and I haven't
heard of anyone using it for years.

Let's save the complexity and build time.

This package was used for some internal Microsoft teams but overrides
a very old version of the MSBuild.CoreXT package (15.0!) and I haven't
heard of anyone using it for years.

Let's save the complexity and build time.
@rainersigwald rainersigwald added this to the VS 17.2 milestone Jan 12, 2022
@rainersigwald rainersigwald added the Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. label Jan 12, 2022
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this is worth an exp/ branch? Not sure who was using it before.

@rainersigwald
Copy link
Member Author

Do you think this is worth an exp/ branch? Not sure who was using it before.

No, I don't, because AFAIK no one has used it in years. The exp branch wouldn't cause them to let us know that it was important to them--only the lack of published packages over time will do that.

@rainersigwald rainersigwald added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Jan 19, 2022
@ladipro ladipro merged commit 717182d into dotnet:main Jan 24, 2022
@rainersigwald rainersigwald deleted the delete-engine-corext-package branch March 28, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants