Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA1506 Element documentation headers should not be followed by blank … #7271

Merged
merged 1 commit into from
Jan 12, 2022
Merged

SA1506 Element documentation headers should not be followed by blank … #7271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Common.globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,7 +987,7 @@ dotnet_diagnostic.SA1504.severity = suggestion
dotnet_diagnostic.SA1505.severity = suggestion

# Element documentation headers should not be followed by blank line
dotnet_diagnostic.SA1506.severity = suggestion
dotnet_diagnostic.SA1506.severity = warning

# Code should not contain multiple blank lines in a row
dotnet_diagnostic.SA1507.severity = suggestion
Expand Down
1 change: 0 additions & 1 deletion src/Framework/ILogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ namespace Microsoft.Build.Framework
// WARNING: VS Automation code for the Tools/Options MSBuild build verbosity setting will be broken
// by changes to this enum (not to mention existing MSBuild clients and vsproject code).
// Please make sure to talk to automation devs before changing it.

[ComVisible(true)]
public enum LoggerVerbosity
{
Expand Down
1 change: 0 additions & 1 deletion src/Framework/Traits.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,6 @@ public enum SdkReferencePropertyExpansionMode
/// <remarks>
/// Clone from ErrorUtilities which isn't (yet?) available in Framework.
/// </remarks>

private static readonly bool s_throwExceptions = String.IsNullOrEmpty(Environment.GetEnvironmentVariable("MSBUILDDONOTTHROWINTERNAL"));

/// <summary>
Expand Down
1 change: 0 additions & 1 deletion src/Utilities/TrackedDependencies/FileTracker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,6 @@ public static string EnsureFileTrackerOnPath(string rootPath)
/// path that matches.
/// </summary>
/// <returns>The full path to Tracker.exe, or <see langword="null" /> if a matching path is not found.</returns>

public static string FindTrackerOnPath()
{
string[] paths = Environment.GetEnvironmentVariable(pathEnvironmentVariableName).Split(pathSeparatorArray, StringSplitOptions.RemoveEmptyEntries);
Expand Down