Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1005 Single line comment should begin with a space #7259

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

elachlan
Copy link
Contributor

Relates to #7174
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1005.md

Used automated code fix. Sorry for the large amount of changes.

@@ -459,8 +459,8 @@ internal static void ResetInstance_ForUnitTestsOnly(BuildEnvironment buildEnviro

private static class BuildEnvironmentHelperSingleton
{
// Explicit static constructor to tell C# compiler
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this? It looks like you deleted a space and replaced it with a space?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was apparently a "NO-BREAK SPACE", which was replaced with a "SPACE".

Copy link
Contributor

@Nirmal4G Nirmal4G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much churn for so little benefit. I would rather not, personally. But sure.

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Jan 12, 2022
@elachlan
Copy link
Contributor Author

This is so much churn for so little benefit. I would rather not, personally. But sure.

Thanks @rainersigwald, Sorry for the increased churn and extra work load.

@Forgind Forgind merged commit fb700f9 into dotnet:main Jan 12, 2022
@elachlan elachlan deleted the SA1005 branch January 12, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants