Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add solution parser documentation #7245

Merged
merged 7 commits into from
Feb 18, 2022
Merged

Add solution parser documentation #7245

merged 7 commits into from
Feb 18, 2022

Conversation

dbelik
Copy link
Contributor

@dbelik dbelik commented Jan 10, 2022

Added a new doc called "solution-parser"

This doc describes expression expansion, build requests and solution file parsing

This commit added a single doc to documentation folder

@dnfadmin
Copy link

dnfadmin commented Jan 10, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

@dnfadmin
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ dbelik sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

Forgind
Forgind approved these changes Jan 15, 2022
View reviewed changes
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation looks great to me, thanks for putting it together! Almost all my comments are adding articles and consolidating to fewer lines.

documentation/solution-parser.md Outdated Show resolved Hide resolved
documentation/solution-parser.md Outdated Show resolved Hide resolved
documentation/solution-parser.md Outdated Show resolved Hide resolved
documentation/solution-parser.md Outdated Show resolved Hide resolved
documentation/solution-parser.md Outdated Show resolved Hide resolved
documentation/solution-parser.md Outdated Show resolved Hide resolved
documentation/solution-parser.md Outdated Show resolved Hide resolved
documentation/solution-parser.md Outdated Show resolved Hide resolved
documentation/solution-parser.md Outdated Show resolved Hide resolved
documentation/solution-parser.md Outdated Show resolved Hide resolved
Forgind
Forgind approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Feb 16, 2022
@Forgind Forgind merged commit 334e448 into dotnet:main Feb 18, 2022
@Forgind
Copy link
Member

Forgind commented Feb 18, 2022

Thanks @dbelik! Sorry it took a while to get this in 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forgind Forgind Forgind approved these changes

Assignees
No one assigned
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbelik @dnfadmin @Forgind