Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA1136 place each enum value on its own line #7203

Merged
merged 7 commits into from
Jan 12, 2022
Merged

SA1136 place each enum value on its own line #7203

merged 7 commits into from
Jan 12, 2022

Conversation

elachlan
Copy link
Contributor

@elachlan elachlan commented Jan 2, 2022

@elachlan elachlan mentioned this pull request Jan 2, 2022
Open
sharwell
sharwell reviewed Jan 2, 2022
View reviewed changes
src/Tasks.UnitTests/ResolveComReference_Tests.cs Outdated Show resolved Hide resolved
src/Tasks/GenerateManifestBase.cs Outdated Show resolved Hide resolved
src/Tasks/GenerateManifestBase.cs Outdated Show resolved Hide resolved
src/Tasks/GenerateApplicationManifest.cs Outdated Show resolved Hide resolved
src/Tasks/FormatVersion.cs Outdated Show resolved Hide resolved
Forgind
Forgind reviewed Jan 4, 2022
View reviewed changes
src/Build/Evaluation/Conditionals/Token.cs Show resolved Hide resolved
src/Build/Graph/ProjectInterpretation.cs Outdated Show resolved Hide resolved
src/Tasks.UnitTests/ResolveComReference_Tests.cs Outdated Show resolved Hide resolved
src/Tasks/BootstrapperUtil/Product.cs Outdated Show resolved Hide resolved
src/Tasks/FormatVersion.cs Outdated Show resolved Hide resolved
src/Tasks/GenerateApplicationManifest.cs Outdated Show resolved Hide resolved
src/Tasks/GenerateManifestBase.cs Outdated Show resolved Hide resolved
src/Tasks/GenerateManifestBase.cs Outdated Show resolved Hide resolved
src/Tasks/StrongNameUtils.cs Outdated Show resolved Hide resolved
Forgind
Forgind approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Jan 12, 2022
@Forgind Forgind merged commit ce29fca into dotnet:main Jan 12, 2022
@elachlan elachlan deleted the SA1136 branch January 12, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell left review comments

@Forgind Forgind Forgind approved these changes

@ladipro ladipro ladipro approved these changes

Assignees
No one assigned
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elachlan @sharwell @ladipro @Forgind