Commits on Aug 2, 2021

1. Make EvaluateStop event adjacent to EvaluateStart …

   It's not well documented, but EventSource requires that the start and stop event IDs
   for a single thing be separated by exactly one. Since this one didn't, we weren't
   getting DURATION_MSEC computed for overall evaluation time in our traces.
   
   See https://github.com/dotnet/runtime/blob/f83a9d9689433ce522b91e74a9631c83847e3b64/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs#L3270.

   

   rainersigwald committed Aug 2, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 11f0851
   • Browse repository at this point

   Copy the full SHA

   11f0851 View commit details

   Browse the repository at this point in the history

2. Update Evaluate* event doc comments

   

   rainersigwald committed Aug 2, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for b298e8e
   • Browse repository at this point

   Copy the full SHA

   b298e8e View commit details

   Browse the repository at this point in the history

3. Include EvaluateStart/Stop in DOTNET_PERFLOG …

   This is a more critical measure than Parse, which is XML->memory, because it
   includes imports, SDK resolution, and MSBuild logic.

   

   rainersigwald committed Aug 2, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 326fd95
   • Browse repository at this point

   Copy the full SHA

   326fd95 View commit details

   Browse the repository at this point in the history

4. Drop Parse from DOTNET_PERFLOG …

   It's pretty rare that the XML parse phase of project load is a signifcant
   part of evaluation time; it's usually a tiny fraction of overall evaluation.

   

   rainersigwald committed Aug 2, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 46690ea
   • Browse repository at this point

   Copy the full SHA

   46690ea View commit details

   Browse the repository at this point in the history