Publish FileAssociation Icons correctly in Single-File ClickOnce publish #6578
Conversation
…ingle-File publish for ClickOnce
|
|
||
| <!-- Include file association icons from Content as loose files --> | ||
| <_FileAssociationIcons Include="%(FileAssociation.DefaultIcon)"/> | ||
| <_ClickOnceFiles Include="@(ContentWithTargetPath)" Condition="'%(Identity)'=='@(_FileAssociationIcons)'"/> |
There was a problem hiding this comment.
I don't think this will work if there's more than one FileAssociation.DefaultIcon. Have you tested that case?
There was a problem hiding this comment.
Good point, I had not. I just tried it and it seems to work.
There was a problem hiding this comment.
Is this the one y'all would like to have for 16.11, or is 17.0 (our current main branch) ok?
Current plan is to fix this for Dev17. We haven't had customers report this corner case failure. If we need to get this into 16.11 at this point, I suppose we need to go through shiproom for approval?
There was a problem hiding this comment.
I didn't understand how the batching would work as written and I spent a bit of time to build my understanding.
This expression has an unqualified metadata reference %(Identity), so it applies the batching rules to all item lists in the expression. Since _FileAssociationIcons and ContentWithTargetPath both have the .ico files as entries, this works fine.
(Someday I will internalize this, but it's not today. And it wasn't two years ago either: #4429)
There was a problem hiding this comment.
Thanks makes sense. Essentially I want to iterate through items in ContentWithTargetPath item list and add the item to _ClickOnceFiles only if it exists in _FileAssociationIcons item list.
Is there a better way to express this in msbuild?
There was a problem hiding this comment.
@rainersigwald
Just want to make sure the change I have is the correct way to express the intent. If so, I will go ahead with the merge.
There was a problem hiding this comment.
Ah, sorry. Yes, this is fine.
|
|
||
| <!-- Include file association icons from Content as loose files --> | ||
| <_FileAssociationIcons Include="%(FileAssociation.DefaultIcon)"/> | ||
| <_ClickOnceFiles Include="@(ContentWithTargetPath)" Condition="'%(Identity)'=='@(_FileAssociationIcons)'"/> |
There was a problem hiding this comment.
Do we need to do something similar for other content files?
There was a problem hiding this comment.
The only content files that need special handling are the file association icons afaik. I don't see any other place where ad-hoc content files are added indirectly as publishing content.
Forgind
added
the
merge-when-branch-open
Ensure file association icons files get published as loose files in Single-File publish for ClickOnce
Fixes #1340931
Context
ClickOnce applications can associate file extension and icons with the application. In this scenario, the icon files should be published. When published in Single-File mode, we fail to publish the icon files.
Changes Made
In Single-File publishing, ClickOnce only publishes the SF Exe and any uncompressed file that cannot go into the bundle. The ico files get ignored. The fix made now ensure that ico files in FileAssociation item list are also published as uncompressed file. These file need be be outside of the bundle so that the ClickOnce installer and runtime can see them.
Testing
CTI tested all configurations (Portable/x64/x86 across FDD/SCD and SF modes).
Notes