Log location of intrinsic tasks #6397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log the Line and Column of add or remove items in ItemGroups inside targets. Previously we could only recover the file from the parent target, but not exactly which line in the file corresponded to the add/remove. Now we can exactly pinpoint which add/remove is executing. No need to log the file because we can recover this information from the parent target. This saves space.
KirillOsenkov
added
Area: Logging
Area: Debuggability
|
Note that this doesn't solve #2473, because it logs only during target execution. Evaluation ItemGroups are not logged. |
Forgind
approved these changes
May 3, 2021
ladipro
approved these changes
May 10, 2021
ladipro
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log the Line and Column of add or remove items in ItemGroups inside targets. Previously we could only recover the file from the parent target, but not exactly which line in the file corresponded to the add/remove.
Now we can exactly pinpoint which add/remove is executing. No need to log the file because we can recover this information from the parent target. This saves space.