-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip hanging test #5995
Skip hanging test #5995
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Fair to say that this hang and #5453 likely have the same root cause? Would it make sense to dupe one of the issues against the other one?
Dupe a PR against an issue? This is very likely the same issue, but since it hasn't been resolved properly, this is a (hopefully temporary) change to make us not suffer as much from it before it's fixed. |
Ah, sorry for not being clearer. I meant closing one of the two GH issues and keeping only one. |
What are the two issues? #5453 and what else? |
Ah! I see. I hadn't been trying to resolve an issue, so I didn't notice there were two issues covering almost identical situations. I closed the older one as a dupe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This test has been hanging repeatedly lately. See, for example:
https://dev.azure.com/dnceng/public/_build/results?buildId=934918&view=logs&j=1522e9b9-b859-5e5f-ec86-a68fc9508baf&t=a8d37b2d-1a39-51d6-c11e-8665c8c9811e