Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip hanging test #5995

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Skip hanging test #5995

merged 2 commits into from
Jan 7, 2021

Conversation

Forgind
Copy link
Member

@Forgind Forgind commented Dec 31, 2020

Copy link
Member

@ladipro ladipro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Fair to say that this hang and #5453 likely have the same root cause? Would it make sense to dupe one of the issues against the other one?

@Forgind
Copy link
Member Author

Forgind commented Jan 4, 2021

Dupe a PR against an issue?

This is very likely the same issue, but since it hasn't been resolved properly, this is a (hopefully temporary) change to make us not suffer as much from it before it's fixed.

@ladipro
Copy link
Member

ladipro commented Jan 4, 2021

Ah, sorry for not being clearer. I meant closing one of the two GH issues and keeping only one.

@Forgind
Copy link
Member Author

Forgind commented Jan 4, 2021

What are the two issues? #5453 and what else?

@ladipro
Copy link
Member

ladipro commented Jan 4, 2021

#5520

@Forgind
Copy link
Member Author

Forgind commented Jan 4, 2021

Ah! I see. I hadn't been trying to resolve an issue, so I didn't notice there were two issues covering almost identical situations. I closed the older one as a dupe.

Copy link
Member

@benvillalobos benvillalobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Forgind Forgind merged commit 56b853f into dotnet:master Jan 7, 2021
@Forgind Forgind deleted the remove-hanging-test branch January 7, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants