Exec: take EchoOff into account when command fails

[tmds]

@rainersigwald

EchoOff is documented to:

If true, the task will not emit the expanded form of Command to the MSBuild log.

[Forgind]

This change looks great, thanks! I'm unsure about what the exit code-sensitive strings should look like, though. Printing The command "EchoOff" exited with code... looks a little awkward to me, but it's good to note that the command wasn't printed...maybe The command exited with code {0}. (Command omitted because EchoOff was set to true.)?

[tmds]

The command exited with code {0}. (Command omitted because EchoOff was set to true.)?

I think the parentheses at the end may easily go unnoticed.

@Forgind do you like one of these?

The command "***" exited with code -1.
The command "(EchoOff)" exited with code -1.
The command "<<EchoOff>>" exited with code -1.

[rainersigwald]

I didn't actually know that Exec overrode the default ToolTask behavior in this way

msbuild/src/Tasks/Exec.cs

Lines 374 to 378 in 743c545

	//Dont print the command line if Echo is Off.
	if (!EchoOff)
	{
	base.LogToolCommand(Command);
	}

Given that, I think this makes sense.

I favor the "***" approach, or a new localized string like [Redacted because EchoOff was set]. The former obviously being easier to implement :)

[rainersigwald]

Hmm. Is it worth preserving this "exited with code" message if we use the scrubbed command from below? It may be useful information, depending on situation--if it's an "always fails with the same code, just go with it" thing you probably don't need that; if it's a "sometimes fails so this is just best effort" it might help chase down a later failure caused by the failure.

[tmds]

I omitted the logging because it enables the user to take action on its own based on the output ExitCode of the Exec task.
This could be custom messages, or other a fail back action.

I'm fine changing this to use the "..." placeholder.

Or we can lower the importance when EchoOff (in addition to using the "...").

@rainersigwald what do you prefer?

[rainersigwald]

I think as-is is ok; we'll see if anyone complains.

[rainersigwald]

Thanks!

[rainersigwald]

I think as-is is ok; we'll see if anyone complains.

[Forgind]

Thanks, @tmds!