Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BaseOutputPath to common targets #5238

Merged
merged 7 commits into from
Dec 7, 2020
Merged

Add BaseOutputPath to common targets #5238

merged 7 commits into from
Dec 7, 2020

Commits on Dec 2, 2020

  1. Add BaseOutputPath to common targets 

    While this is not officially supported on non-sdk projects,
 NuGet Pack targets need a common output path
 to put '.nupkg' across both type of projects
    @Nirmal4G
    Nirmal4G committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    2f335b0 View commit details
    Browse the repository at this point in the history

  2. Use property functions within MSBuild namespace, wherever possible 

    Replace 'HasTrailingSlash' conditional function with '[MSBuild]::EnsureTrailingSlash' property function
Replace '[System.IO.Path]::Combine' property function with '[MSBuild]::NormalizePath' and '[MSBuild]::NormalizeDirectory' property functions
    @Nirmal4G
    Nirmal4G committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    1e779a5 View commit details
    Browse the repository at this point in the history

  3. Fallback to legacy behavior for Configuration/Platform validation 

    when using OutputPath without BaseOutputPath
    @Nirmal4G
    Nirmal4G committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    9a7012e View commit details
    Browse the repository at this point in the history

  4. Use 'Path.Combine' property function in place of using slashes to com… 

    …bine paths

Usually, either '[MSBuild]::NormalizePath' or '[MSBuild]::NormalizeDirectory' property functions would be preferred for these cases.
But, there's a bug (on Windows) which occurs when a drive relative path like 'C:Projects' is specified and it fails to return to the project directory.

Usually, '[System.IO.Path]::Join' would be most preferred in this context. But, it's not available in NETFX. So, '[System.IO.Path]::Combine' is used instead.
    @Nirmal4G
    Nirmal4G committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    601ed38 View commit details
    Browse the repository at this point in the history

  5. Add tests for checking 'OutputPath' properties 

    Making sure that existing 'OutputPath' scenarios work, while allowing the use of 'BaseOutputPath' property
    @Nirmal4G
    Nirmal4G committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    97bc2b5 View commit details
    Browse the repository at this point in the history

  6. Update comments on legacy Configuration/Platform check 

    Adjust the wording to make it simple, brief and clear.

Co-Authored-By: Rainer Sigwald <[email protected]>

> Fixup with original commit when this patch is approved.
    @Nirmal4G
    Nirmal4G committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    17c4944 View commit details
    Browse the repository at this point in the history

  7. Add a missing bracket 

    Silly ME!

There were a lot of build errors from the Fakes targets.
I was banging my head on which change caused this but finally found it.
Guess being sick has its perks.
    @Nirmal4G
    Nirmal4G committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    f7e97bd View commit details
    Browse the repository at this point in the history