Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo consume Roslyn from new location #1406

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Redo consume Roslyn from new location #1406

merged 1 commit into from
Dec 7, 2016

Conversation

rainersigwald
Copy link
Member

Reverts #1391

@rainersigwald
Copy link
Member Author

@OmarTawfik this will bring back the changes for our rc3 branch.

@rainersigwald rainersigwald force-pushed the revert-1391-undoroslynfolder branch from 90663e1 to b6396d7 Compare November 29, 2016 20:09
rainersigwald
rainersigwald commented Nov 29, 2016
View reviewed changes
Copy link
Member Author

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that should be reviewable now @AndyGerlicher

targets/DeployDependencies.proj
</RuntimeProjectJson>
</ItemGroup>

<Target Name="RestoreRuntimePackages"
Inputs="$(DnuToolPath);@(RuntimeProjectJson)"
Inputs="$(DnuToolPath);$(RuntimeProjectJson)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bogus

targets/DeployDependencies.proj
@@ -109,7 +113,7 @@

<Target Name="DeployRuntime"
DependsOnTargets="RestoreRuntimePackages"
Outputs="%(RuntimeProjectJson.LockFile).IntentionallyDoesNotExistSoThisAlwaysRuns">
Outputs="%(RuntimeProjectJson.DestinationFolder)\dummy">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is this.

@AndyGerlicher
Copy link
Contributor

@dotnet-bot test Windows_NT Build for Desktop please

@rainersigwald rainersigwald force-pushed the revert-1391-undoroslynfolder branch from b6396d7 to 501f6ab Compare December 1, 2016 14:51
@rainersigwald
Copy link
Member Author

This went in to Roslyn with dotnet/roslyn#15222, so it should go in here as well.

@rainersigwald rainersigwald merged commit 07b0b36 into xplat Dec 7, 2016
@rainersigwald rainersigwald deleted the revert-1391-undoroslynfolder branch December 7, 2016 00:16
AndyGerlicher pushed a commit that referenced this pull request Jan 4, 2017
@rainersigwald @AndyGerlicher
Redo consume Roslyn from new location (#1406)
043ac63
@rainersigwald rainersigwald mentioned this pull request Jan 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyGerlicher AndyGerlicher AndyGerlicher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MSBuild 15.1 RC.3
Development

Successfully merging this pull request may close these issues.
4 participants
@rainersigwald @AndyGerlicher @dnfclas @Sarabeth-Jaffe-Microsoft