Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-in CPM for buildcheck template #10607

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Opt-in CPM for buildcheck template #10607

merged 1 commit into from
Sep 11, 2024

Conversation

JanKrivanek
Copy link
Member

Context

We are having Microsoft.Build package version managed centrally - but we do not opt-in to the feature - as a result restore will not respect our setting in Directory.Build.props.

Testing

Manual runs

Before:

  C:\repro\Contoso.BuildChecks.csproj : warning NU1604: Project dependency Microsoft.Build does not contain an inclusive lower bound. Include a lower bound in the dependency version to ensure consistent restore results.

  (...)

  C:\repro\Contoso.BuildChecks\Check1.cs(2,23): error CS0234: The type or namespace name 'Experimental' does not exist in the namespace 'Microsoft.Build' (are you missing an assembly reference?)

  (...)
  Build failed with 8 error(s) and 2 warning(s) in 1.6s

After:

 (...)
 Build succeeded with 12 warning(s) in 3.0s

Note: The warnings in the sample above are caused by unrelated issues (will be tracked separately)

@JanKrivanek JanKrivanek enabled auto-merge (squash) September 3, 2024 11:40
@JanKrivanek JanKrivanek merged commit db5b3ef into main Sep 11, 2024
10 checks passed
@JanKrivanek JanKrivanek deleted the JanKrivanek-patch-5 branch September 11, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants