Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed fix to Check Template #10542

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Renamed fix to Check Template #10542

merged 2 commits into from
Aug 22, 2024

Conversation

maridematte
Copy link
Contributor

@maridematte maridematte commented Aug 21, 2024

Summary

Fixes #10537
Change classes to match the new naming convention for BuildCheck , otherwise the template won't be working.

Customer Impact

When a customer instantiates a template, it's not buildable due to the changed naming in MSBuild API.

Regression?

Yes, was introduced in scope of renaming: #10491

Testing

Locally, the template isn't covered by MSBuild yet.

Risk

No risks, doesn't contain any changes in logic.

@YuliiaKovalova YuliiaKovalova merged commit d17ec72 into dotnet:main Aug 22, 2024
10 checks passed
@maridematte maridematte deleted the 10537 branch October 22, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename to CheckRule and CheckConfiguration correspondently
5 participants