Rename - fix casing of IMSBuildElementLocation #10507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem. Just did a quick check over the repo. Lot of casing mistakes. In public APIs also, apart from the one here. Fix it or leave it!? |
Would it be BuildCheck API, than we can afford changing it as there is no risk of breakage (the feature is new and experimental). For other preexisting API we need to stick to it - not to break downstream consumers |
YuliiaKovalova
approved these changes
Aug 11, 2024
maridematte
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10457 (comment)
Context
Renaming only change.
Casing of
IMSBuildElementLocationwas incorrect (IMsBuildElementLocation)FYI @Nirmal4G (thx for bringing this up)