Fix wrong paths in SharedOutputPathAnalyzer. #10472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Check (dotnet#10238)" This reverts commit b100f12.
|
@AR-May , is it possible to cover it with some UTs to illustrate what problem got resolved? |
Added some extra test coverage. Test that illustrates this particular bug is |
JanKrivanek
approved these changes
Aug 2, 2024
f-alizada
approved these changes
Aug 5, 2024
AR-May
added
the
Priority:1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10414
Context
PR #10238 added normalization of the path (which includes getting full path) before the project directory path is added to it. This led to the relative path being turned into a full path using CurrentDirectory instead of the project directory. This leads to enormous amount of false-positive analyzer's warnings (400 instead of 3) that cause the hang. This PR fixes the bug with paths and does not fix actual cause of a hang.
Changes Made
Reverted the PR #10238 and instead added normalization of the path later in the code when the project path is already combined with the relative path.
Testing
unit tests and local runs