Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build status badged public and internal #10275

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

f-alizada
Copy link
Contributor

Context

Add the badge statuses to the main ReadMe file.

Changes Made

Add the links to the badge statuses :)

Testing

Local only. could be checked here:
https://github.com/f-alizada/msbuild/tree/dev/f-alizada/add-build-status

@f-alizada f-alizada self-assigned this Jun 20, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@f-alizada f-alizada changed the title Add build status badged public and private Add build status badged public and internal Jun 20, 2024
@rainersigwald
Copy link
Member

We had this for a long time and I wound up removing it because we didn't find it very helpful--what are you hoping to get from having this?

@f-alizada
Copy link
Contributor Author

We had this for a long time and I wound up removing it because we didn't find it very helpful--what are you hoping to get from having this?

  • Public visibility (for internal pipeline status)
  • Benefit: More easy access to the pipelines

@rainersigwald
Copy link
Member

Public visibility into internal builds doesn't necessarily help external folks much, since they don't do anything that is directly interesting right off.

I'm not opposed if other folks want it. Just found that when we had it it went red for months or years and no one ever looked at it :)

@f-alizada
Copy link
Contributor Author

Public visibility into internal builds doesn't necessarily help external folks much, since they don't do anything that is directly interesting right off.

I'm not opposed if other folks want it. Just found that when we had it it went red for months or years and no one ever looked at it :)

Oh that something I didn't know to be honest.
Public visibility is not for investigation of internal builds, but that we are keeping it green :)

I'll keep the PR open to allow other to see, thank you @rainersigwald

@rainersigwald
Copy link
Member

Public visibility is not for investigation of internal builds, but that we are keeping it green :)

IIRC what happened was we change build definitions or something and forgot to update the badge so it was red for a very long time. A fixable problem!

@f-alizada f-alizada merged commit c260ac1 into dotnet:main Jun 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants