Drop MSBuildTaskHost resources from ARM64 #10230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These resources were added to the ARM64 subfolder in dotnet#10023, but I don't think they're needed: there's no .NET Framework 3.5 for ARM64 and `MSBuildTaskHost.exe` isn't in the ARM64 folder itself, so I think we can remove these files. There was also a build race condition involving the .resources.dll files, which is how I found this. The `Arm64ProjectReference` wasn't enough to get them built.
|
@JaynieBai could I ask you to take a look at this? In the bug you fixed I said I wanted "all resources" but it looks like that was too much. |
JaynieBai
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Tested with build in https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9727760&view=results
|
Thanks @JaynieBai! |
JanKrivanek
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These resources were added to the ARM64 subfolder in #10023, but I don't think they're needed: there's no .NET Framework 3.5
for ARM64 and
MSBuildTaskHost.exeisn't in the ARM64 folder itself, so I think we can remove these files.There was also a build race condition involving the .resources.dll files, which is how I found this. The
Arm64ProjectReferencewasn't enough to get them built.