Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap DumpExceptionToFile with try/catch for outofmemory #10165

Conversation

YuliiaKovalova
Copy link
Member

@YuliiaKovalova YuliiaKovalova commented May 21, 2024

Fixes #
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1748184

Context

Some customers catch out of memory on our attempt to dump errors to local file.
This change prevents a crash from that.

Co-authored-by: Rainer Sigwald <[email protected]>
Copy link
Member

@AR-May AR-May left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Shared/ExceptionHandling.cs Show resolved Hide resolved
src/Shared/ExceptionHandling.cs Outdated Show resolved Hide resolved
@YuliiaKovalova YuliiaKovalova enabled auto-merge (squash) May 24, 2024 16:43
@YuliiaKovalova YuliiaKovalova merged commit 6c74871 into dotnet:main May 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants