Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle specific dispose cases in xml-related utils #10059

Conversation

YuliiaKovalova
Copy link
Member

@YuliiaKovalova YuliiaKovalova commented Apr 23, 2024

Fixes

Failed insertion in VS (it had required tests failures)

Solution

Delegate stream handling to the caller (it is needed later)

Test run

https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/545969

@YuliiaKovalova YuliiaKovalova marked this pull request as draft April 23, 2024 08:32
@YuliiaKovalova YuliiaKovalova changed the title Handle specific dispose in ManifestReader Handle specific dispose cases in xml-related utils Apr 23, 2024
@YuliiaKovalova YuliiaKovalova marked this pull request as ready for review April 23, 2024 15:45
@YuliiaKovalova YuliiaKovalova merged commit 64efd72 into dotnet:main Apr 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants