Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HybridDictionary has indexer (accepting object) which recursively calls itself instead of calling to types overload. #77

Closed
serjic opened this issue Apr 24, 2015 · 1 comment
Closed

HybridDictionary has indexer (accepting object) which recursively calls itself instead of calling to types overload. #77

serjic opened this issue Apr 24, 2015 · 1 comment
Labels
help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. triaged

Comments

@serjic
Copy link

serjic commented Apr 24, 2015

Probably the intended implementation was:

    public object this[object key]
    {
        get { return ((IDictionary<TKey, TValue>)this)[(TKey)key]; }
        set { ((IDictionary<TKey, TValue>)this)[(TKey)key] = (TValue)value; }
    }
@AndyGerlicher AndyGerlicher added the help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. label May 12, 2015
@AndyGerlicher
Copy link
Contributor

Team triage: This is probably dead code and could be deleted.

AndyGerlicher added a commit to AndyGerlicher/msbuild that referenced this issue Feb 15, 2017
@AndyGerlicher
Fix invalid indexer in HybridDictionary
416a0c1 
Indexer (defined in interface) implemented that recursively calls
itself. Nothing called this code, but if it did it would be wrong
(stack overflow).

Closes dotnet#77
AndyGerlicher added a commit to AndyGerlicher/msbuild that referenced this issue Feb 15, 2017
@AndyGerlicher
Fix invalid indexer in HybridDictionary
1fbc62e 
Indexer (defined in IDictionary) implemented in a way that recursively
calls itself. Nothing called this code, but if it did it would be wrong
(stack overflow).

Closes dotnet#77
@AndyGerlicher AndyGerlicher mentioned this issue Feb 15, 2017
Merged
AndyGerlicher added a commit that referenced this issue Feb 16, 2017
@AndyGerlicher
Fix invalid indexer in HybridDictionary (#1706)
e55ebc1 
Indexer (defined in IDictionary) implemented in a way that recursively
calls itself. Nothing called this code, but if it did it would be wrong
(stack overflow).

Closes #77
radical added a commit to radical/msbuild that referenced this issue Dec 12, 2018
@radical
[mono] Add Microsoft.NET.Sdk.Razor missed in the last update (dotnet#77)
c258604 
Missed committing the sdk files in
3f83070 !

cli commit: d36e5ce

Microsoft.NET.Sdk.Razor: 2.1.0

Version from:
    https://github.com/dotnet/cli/blob/d36e5ce1619640f4516c1e89ef20cf52f1a32878/build/DependencyVersions.props

(A future fix should guard against this kinda mistake)

Fixes mono/mono#11214 .
radical added a commit to radical/msbuild that referenced this issue Dec 12, 2018
@radical
[mono] Add Microsoft.NET.Sdk.Razor missed in the last update (dotnet#77)
74343bd 
Missed committing the sdk files in
3f83070 !

cli commit: d36e5ce

Microsoft.NET.Sdk.Razor: 2.1.0

Version from:
    https://github.com/dotnet/cli/blob/d36e5ce1619640f4516c1e89ef20cf52f1a32878/build/DependencyVersions.props

(A future fix should guard against this kinda mistake)

Fixes mono/mono#11214 .

(cherry picked from commit c258604)
radical added a commit to radical/msbuild that referenced this issue Dec 12, 2018
@radical
Revert "[mono] Add Microsoft.NET.Sdk.Razor missed in the last update (d…
7fd217d 
…otnet#77)"

This reverts commit 74343bd.

Pushed by mistake!
radical added a commit to radical/msbuild that referenced this issue Dec 12, 2018
@radical
[mono] Add Microsoft.NET.Sdk.Razor missed in the last update (dotnet#77)
1e74abf 
Missed committing the sdk files in
3f83070 !

cli commit: d36e5ce

Microsoft.NET.Sdk.Razor: 2.1.0

Version from:
    https://github.com/dotnet/cli/blob/d36e5ce1619640f4516c1e89ef20cf52f1a32878/build/DependencyVersions.props

(A future fix should guard against this kinda mistake)

Fixes mono/mono#11214 .

(cherry picked from commit c258604)
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@serjic @AndyGerlicher @AR-May