Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TargetSkippedEventArgs.TargetSkipReason can be None when reading old binlogs #6563

Closed
KirillOsenkov opened this issue Jun 15, 2021 · 1 comment · Fixed by #6577
Closed

TargetSkippedEventArgs.TargetSkipReason can be None when reading old binlogs #6563

KirillOsenkov opened this issue Jun 15, 2021 · 1 comment · Fixed by #6577
Assignees
@KirillOsenkov
Labels
Area: Logging triaged

Comments

@KirillOsenkov
Copy link
Member

This assert fires when playing back a version 13 binlog into the latest (version 14) binlog:

msbuild/src/Build/Logging/BinaryLogger/BuildEventArgsWriter.cs

Line 450 in aa78fc6

ErrorUtilities.VerifyThrow(e.SkipReason != TargetSkipReason.None, "TargetSkippedEventArgs.SkipReason needs to be set");

TargetSkipReason is None
@KirillOsenkov KirillOsenkov self-assigned this Jun 15, 2021
@KirillOsenkov
Copy link
Member Author

This is where TargetSkipReason was added:
#6402

KirillOsenkov added a commit that referenced this issue Jun 17, 2021
@KirillOsenkov
Infer target skip reason from older binlogs
36dcafa 
Remove an assert that is too aggressive. When reading old binlogs the TargetSkipReason is not known, so TargetSkipReason.None is a valid state.

We can do a best effort and infer the skip reason for format version 13.

Fixes #6563
@KirillOsenkov KirillOsenkov mentioned this issue Jun 17, 2021
Merged
rainersigwald pushed a commit that referenced this issue Jun 17, 2021
@KirillOsenkov
Infer target skip reason from older binlogs (#6577)
4945f05 
Remove an assert that is too aggressive. When reading old binlogs the TargetSkipReason is not known, so TargetSkipReason.None is a valid state.

We can do a best effort and infer the skip reason for format version 13.

Fixes #6563
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KirillOsenkov KirillOsenkov

Labels
Area: Logging triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Infer target skip reason from older binlogs dotnet/msbuild
2 participants
@KirillOsenkov @AR-May