Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trailing commas in solution filters #6317

Closed
Youssef1313 opened this issue Apr 1, 2021 · 3 comments · Fixed by #6346
Closed

Allow trailing commas in solution filters #6317

Youssef1313 opened this issue Apr 1, 2021 · 3 comments · Fixed by #6346
Labels
needs-triage Have yet to determine what bucket this goes in.

Comments

@Youssef1313
Copy link
Member

Have a slnf with trailing comma and try to restore, you get the following error:

Solution file error MSB5025: Json in solution filter file "path\to\filter.slnf" is incorrectly formatted.

See dotnet/aspnetcore#31438

@Youssef1313 Youssef1313 added the needs-triage Have yet to determine what bucket this goes in. label Apr 1, 2021
@benvillalobos
Copy link
Member

Where does an issue like this originate? Where did the comma come from?

@Youssef1313
Copy link
Member Author

@benvillalobos For aspnetcore repository, it should have been added manually.

@rainersigwald
Copy link
Member

We should match the VS behavior here: if it allows trailing commas so should MSBuild.

cc @Forgind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Have yet to determine what bucket this goes in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants