-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[net7.0] Update dependencies from xamarin/xamarin-android #9968
Closed
dotnet-maestro
wants to merge
42
commits into
net7.0
from
darc-net7.0-ad2b83ef-daac-46c0-ac00-901dfe922996
Closed
Changes from 14 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
f8f4b5f
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] 06165ad
Update eng/Versions.props
rmarinho 9d2a804
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] abfa3da
Merge branch 'net7.0' into darc-net7.0-ad2b83ef-daac-46c0-ac00-901dfe…
jonathanpeppers e584f88
Update dependencies from https://github.com/xamarin/xamarin-macios bu…
dotnet-maestro[bot] 03baa98
Merge branch 'net7.0' into darc-net7.0-ad2b83ef-daac-46c0-ac00-901dfe…
rmarinho 03b893f
NRT annotation for iOS
jonathanpeppers 22d0f1b
Attempt to workaround iOS analyzer check
jonathanpeppers db165c6
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] 2c86de8
Revert "Attempt to workaround iOS analyzer check"
jonathanpeppers 99e15aa
#pragma for CA1416
jonathanpeppers 65c648e
OperatingSystem.IsMacCatalystVersionAtLeast(14)
jonathanpeppers 58a5cfb
Revert "OperatingSystem.IsMacCatalystVersionAtLeast(14)"
jonathanpeppers 78bfd4d
#pragma warning disable CA1416
jonathanpeppers 596421f
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] f7686b7
Revert "#pragma warning disable CA1416"
jonathanpeppers 6ec4b93
Revert "#pragma for CA1416"
jonathanpeppers 015374f
Workaround CA1416 repo-wide
jonathanpeppers dc2a5b9
Fix NRT warnings for NSUrl.AbsoluteString
jonathanpeppers 2ceb54b
Update dependencies from https://github.com/xamarin/xamarin-macios bu…
dotnet-maestro[bot] 4475671
Update dependencies from https://github.com/xamarin/xamarin-macios bu…
dotnet-maestro[bot] bdaaa9c
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] 397c14b
Set $(RuntimeIdentifier) for maccatalyst-x64
jonathanpeppers cc05c02
Revert "Set $(RuntimeIdentifier) for maccatalyst-x64"
jonathanpeppers 96221aa
Revert "Update dependencies from https://github.com/xamarin/xamarin-m…
jonathanpeppers c3d616d
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] 79f0dbf
Update dependencies from https://github.com/xamarin/xamarin-macios bu…
dotnet-maestro[bot] 93efde3
Fix for Resizetizer/Catalyst interaction
jonathanpeppers d3c21d2
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] 0a75a35
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] 829d0b5
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] 08ee17a
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] 480234e
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] 619ae03
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] 69263f9
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] c7013a0
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] a1622ee
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] d60ebe8
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] 33436ad
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] 9a9d0d2
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] 6e314b9
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] bef3b65
Update dependencies from https://github.com/xamarin/xamarin-android b…
dotnet-maestro[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rolfbjarne this doesn't quite feel right, I got the warning above building the net7.0-ios target framework. Did anything change with the
MaximumFramesPerSecond
API?Or is it a bug in the analyzer that emits
CA1416
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once I fixed a couple in
Core.csproj
, it just seems like a lot more come up now:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonathanpeppers did MAUI recently change their default min OS version? At the very least the warning about ContentInsetAdjustmentBehavior is correct (it's available on iOS 11+, and that hasn't changed)
If MAUI didn't change the min OS version, I think this is an analyzer bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filed dotnet/roslyn-analyzers#6158