-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[net6.0][Core]Fixes wrong declared CommandMapper types #9930
[net6.0][Core]Fixes wrong declared CommandMapper types #9930
Conversation
Hey there @myroot! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Can you retarget this pr to release/6.0.5xx-sr5? Then we can get into the upcoming release. |
Sure |
563663b
to
f0c85d8
Compare
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattleibow i think the API changes are wrong no? we should add on unshipped ? the ***REMOVE and add the new API
Ah yeah |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Description of Change
Some Handlers are using missmatched types on
CommandMapper
. It makes me hard to add command mapper so I fix itfor example
maui/src/Core/src/Handlers/IndicatorView/IndicatorViewHandler.cs
Line 31 in f0a814c
IndicatorView must use IIndicatorView type as VirtualView type but it use IActivityIndicator,
I think, It seems mistake. if it is not mistake, let me know