Remove SplitDrawable from Shell code #9896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The
SplitDrawableadded to the DecorView can lead to some odd behavior with Shell. As you can see from the modified device tests I have to account for its existence otherwiseAndroidstarts drawing the surface with a really odd schmear effect and everything breaks. I'm currently fixing up the code to allow for the root page on the window to get swapped out and I'd have to account for adding/removing theSplitDrawablewhen the user switches out of shell.Given that even the original comment seems to allude to it only being useful in testing scenarios and not actual scenarios. I'm just going to remove it.
Issues Fixed
Fixes #5217